fix: send cli: only override method if recipient is a "0x" address #12328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
🤞 I think this addresses the original concern
ping @Stebalien anyway, he can look after the fact
|
Yep, lgtm! |
rjan90
pushed a commit
that referenced
this pull request
Aug 12, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12326 .