Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] chore: blockstore: proxy Put/Delete to the *Many variants #12313

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

ribasushi
Copy link
Collaborator

There are no perf gains to be had here anyway
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our discussion, IIRC: the slight optimization in the single-block case doesn't make up for the massive code duplication.

@Stebalien Stebalien merged commit 5fdc75c into filecoin-project:master Jul 27, 2024
82 checks passed
@Stebalien
Copy link
Member

Thank you!

@ribasushi ribasushi deleted the chore/bs_proxy_singles branch July 27, 2024 14:59
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 17, 2024
There are no perf gains to be had here anyway
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
There are no perf gains to be had here anyway
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
There are no perf gains to be had here anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants