fix: eth: make tx hash immediately available in lookup db after submission #12219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even in the current flow, messages that have not landed on chain will be added to this txn -> hash DB on message pool submission (really, it's just a mapping without any guarantees of whether the txn has landed or not). So, this change is fine. However, we should NOT error out the API just because the DB update fails. |
07a7793 to
2b662bf
Compare
aarshkshah1992
approved these changes
Jul 15, 2024
|
Please feel free to merge once CI is green. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12218
See #12218 for gory details on why this is necessary. This should fix any case where someone does an eth
sendRawTransactionand it's not immediately available via other APIs that expect to be able to translate the eth tx hash to a Filecoin message CID (internally or viaEthGetMessageCidByTransactionHashorEthGetTransactionHashByCid).