fix: ETH getLogs: fix slowness at head and ignore null blocks #12207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
commented
Jul 10, 2024
aarshkshah1992
commented
Jul 10, 2024
aarshkshah1992
commented
Jul 10, 2024
rvagg
reviewed
Jul 11, 2024
rvagg
reviewed
Jul 11, 2024
rvagg
approved these changes
Jul 11, 2024
|
@rvagg Addressed your review here. |
rvagg
approved these changes
Jul 11, 2024
|
Test is a flaky. Added to #12001. |
aarshkshah1992
added a commit
that referenced
this pull request
Jul 11, 2024
* fix get logs slowness and handling of null blocks
aarshkshah1992
added a commit
that referenced
this pull request
Jul 11, 2024
* fix get logs slowness and handling of null blocks
aarshkshah1992
added a commit
that referenced
this pull request
Jul 17, 2024
* fix get logs slowness and handling of null blocks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary patch for the v1.28 release to fix some of the issues mentioned in #12205.
The right thing to do here is revisit how all the ETH RPC APIs deal with the "latest" flag and ensure they are "deferred execution-safe". We also need to make the Event Index aware of null blocks(or atleast have a way to ensure that a given height resulted in a null block and so it has already "processed" the events for that height). Let's prioritise this as part of our ETH RPC work.