Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release:v1.27.1 #12138

Merged
merged 114 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
1b6bffd
fix: curio: Update pgx imports, fix db_storage alloc
magik6k Apr 20, 2024
c2dd674
feat: curioweb: Improve task_history indexes (#11911)
magik6k Apr 24, 2024
10f7b6e
mod tidy
magik6k Apr 30, 2024
6bbe090
Event index should be unique for tipsets (#11952)
aarshkshah1992 May 1, 2024
ed9b1b1
chore: bump build version in master (#11946)
rjan90 May 2, 2024
ecc82d4
feat: curioweb: Show piece info on the sector page (#11955)
magik6k May 2, 2024
00edad4
curio: feat: break trees task into TreeD(prefetch) and TreeRC (#11895)
LexLuthr May 2, 2024
b50049a
fix: ci: use filecoin-ffi hash to cache make deps outputs (#11961)
galargh May 3, 2024
441f599
fix: curio: node UI & darwin gpu count (#11950)
snadrus May 4, 2024
1b2dde1
chore: docs: Update skeleton guide (#11960)
rjan90 May 4, 2024
d6d4fee
Bump pubsub-dep (#11966)
rjan90 May 6, 2024
2d57bfe
feat: Skeleton for nv23 (#11964)
rjan90 May 7, 2024
01ec229
feat: curio: Keep more sector metadata in the DB long-term (#11933)
magik6k May 7, 2024
ebf1e00
feat: curio: docker devnet (#11954)
LexLuthr May 7, 2024
33876bf
fix: curio/lmrpc: Check ParkPiece success before creating sectors (#1…
magik6k May 8, 2024
22ccaf9
feat: curio: alertManager (#11926)
LexLuthr May 8, 2024
6b353e5
add ETH addrs API to Gateway (#11979)
aarshkshah1992 May 8, 2024
6fa6a04
fix: update go-jsonrpc to v0.3.2
LesnyRumcajs May 8, 2024
4f70204
docs: rpc: document go-jsonrpc behaviour change
rvagg May 9, 2024
f5b6c4e
curio cfg edit: ux cleanups (#11985)
snadrus May 10, 2024
6a81103
chore: lint: update golangci lint config
rvagg May 9, 2024
26d3fd2
chore: lint: fix lint errors with new linting config
rvagg May 9, 2024
1882525
chore: lint: address feedback from reviews
rvagg May 13, 2024
af4b680
chore: remove unmaintained bootstrappers (#11983)
rjan90 May 13, 2024
7e005be
Update SupportedProofTypes (#11988)
rjan90 May 13, 2024
f5dd766
Produce DEB files for amd64 for openCL and cuda (#11885)
snadrus May 13, 2024
84b08fc
feat:state:Ignore market balance after nv23 (#11976)
ZenGround0 May 13, 2024
74172ba
Revert "Update SupportedProofTypes (#11988)" (#11990)
rjan90 May 14, 2024
d0bbb0b
ci: fix when sorted pr checks workflow is executed
galargh Apr 22, 2024
af31126
feat: libp2p: Lotus stream cleanup (#11993)
aarshkshah1992 May 14, 2024
672864a
Remove "provider" relics (#11992)
snadrus May 14, 2024
b38dadb
fix: copy Flags field from SectorOnChainInfo
rvagg May 6, 2024
e14a85b
fix: curio: Drop FKs from pipeline to fix retry loops (#11973)
magik6k May 15, 2024
3d6ae22
chore: update go-data-transfer and go-graphsync
rvagg May 16, 2024
3ee0911
ci: deprecate circle ci in favour of github actions (#11786)
galargh May 16, 2024
f098fc2
feat: api: add SectorNumber to MarketDealState (nv22)
rvagg May 16, 2024
6dc4ebd
doc: eth: restore comment lost in linter cleanup
rvagg May 17, 2024
bedd696
fix non existing sector (#12012)
LexLuthr May 17, 2024
0da9646
fix sector UI (#12016)
LexLuthr May 20, 2024
1afe58d
fix actor string (#12019)
LexLuthr May 20, 2024
db105f1
fix: curio taskstorage: Don't try to free reservations by nulled Task…
magik6k May 20, 2024
04ae416
chore: update drand (#12021)
Stebalien May 21, 2024
967524a
chore: update yugabyte deps (#12022)
Stebalien May 21, 2024
7e3846c
feat: curio: allow multiple pieces per sector (#11935)
LexLuthr May 22, 2024
75ca4de
gui-listen fix (#12013)
snadrus May 22, 2024
cfbe59d
fix: ci: keep lotus checkout clean in the release workflow (#12028)
galargh May 22, 2024
7dae7dd
fix: harmonydb: Use timestampz instead of timestamp across the schema…
magik6k May 22, 2024
081efa4
fix: hello: avoid dialing when fetching hello tipset (#12032)
Stebalien May 23, 2024
1d220f2
Bump go-jsonrpc to v0.4.0 (#12034)
rjan90 May 23, 2024
9391548
src: chain: remove C dependency from builtin types (#12015)
ribasushi May 23, 2024
c1f99c5
feat: curio ffiselect: Isolate gpu calls in a subprocess (#11994)
snadrus May 23, 2024
9983c46
fix logs (#12036)
LexLuthr May 23, 2024
4088706
chore: fix some function names (#12031)
yumeiyin May 24, 2024
803acdf
feat: curio: wdPost and wnPost alerts (#12029)
LexLuthr May 24, 2024
759709b
fix: itests: Fix flaky curio itest (#12037)
magik6k May 24, 2024
9851d35
feat: curio: jsonrpc in webui (#11904)
magik6k May 24, 2024
1879570
chore: fix function names (#12043)
tomfees May 27, 2024
6302607
chore: libp2p: update to v0.34.1 (#12027)
aarshkshah1992 May 27, 2024
eed108e
revert go version change (#12050)
aarshkshah1992 May 28, 2024
62228e1
chore: pin golanglint-ci to v1.58.2 (#12054)
rvagg May 28, 2024
47fde12
chore: ci: request contents read permissions explicitly in gha (#12055)
galargh May 28, 2024
f97036c
Move curio packages to curiosrc
magik6k May 24, 2024
76459fc
Remove Ensemble dep on Curio
magik6k May 24, 2024
2a4b1ad
make gen
magik6k May 24, 2024
dce7f5d
Trim harmonydb schema to what's needed here
magik6k May 27, 2024
bcdca4d
Drop curio-related sources
magik6k May 27, 2024
0d96c6e
make gen
magik6k May 27, 2024
dc5cab9
more curio cleanup
magik6k May 27, 2024
2e9929d
Add accidentally deleted 20240401-storage-miner-filter.sql
magik6k May 27, 2024
110da93
Remove curio from Dockerfile
magik6k May 28, 2024
a5ec2fb
fix: ci: use custom GITHUB_TOKEN for GoReleaser (#12059)
galargh May 29, 2024
cf8d187
fix: ci: publish correct docker tags on workflow dispatch (#12060)
galargh May 29, 2024
0a51a0a
feat!: build: separate miner and node version strings
rvagg May 23, 2024
41ebef8
fix: storage: Fix a race in GenerateWindowPoStAdv (#12064)
magik6k Jun 3, 2024
6bc04c8
feat: cli,events: speed up backfill with temporary index
rvagg May 2, 2024
423d8a7
chore: more clearly copy query types, & fix transaction
rvagg May 6, 2024
c9c0707
feat: ETH compatibility in Filecoin : Support Homestead and EIP-155 E…
aarshkshah1992 Jun 5, 2024
469960c
cleanup: Lotus client: remove markets and deal-making from Lotus Cli…
aarshkshah1992 Jun 5, 2024
e3deda0
cleanup: miner: remove markets and deal-making from Lotus Miner (#12005)
aarshkshah1992 Jun 5, 2024
5993841
test: actors: manual CC onboarding and proving integration test (#12017)
rvagg Jun 6, 2024
730c96e
src: lint: bump golangci-lint to 1.59, address unchecked fmt.Fprint*
rvagg Jun 4, 2024
fb3fc1f
fix: test: no snap deals in immutable deadlines (#12071)
aarshkshah1992 Jun 6, 2024
8f94aad
feat: Add trace transaction API (#12075)
snissn Jun 7, 2024
06f8fdc
chore: releases: merge `releases` branch to master (#12076)
rjan90 Jun 10, 2024
821836d
Bump version - make gen/make docsgen
rjan90 Jun 7, 2024
961039c
Update changelog
rjan90 Jun 7, 2024
8f2c4bb
Bump NodeBuildVersion to v1.27.1-rc1
rjan90 Jun 9, 2024
991c356
Add Lotus-Miner / Curio related changes
rjan90 Jun 9, 2024
018bda1
Update date and upgrade warnings
rjan90 Jun 9, 2024
6e13eac
Merge pull request #12077 from filecoin-project/prep-v1271-rc1
rjan90 Jun 11, 2024
7f4e316
fix: ci: do not use deprecated --debug goreleaser flag (#12086)
galargh Jun 14, 2024
6f1fc67
chore: deals: remove forgotten graphsync references (#12084)
ribasushi Jun 14, 2024
ab1cd85
chore: types: remove more items forgotten after markets (#12095)
ribasushi Jun 17, 2024
9772b1c
fix: ETH RPC API: ETH Call should use the parent state root of the su…
aarshkshah1992 Jun 11, 2024
5414ca9
Update changelog to RC2
rjan90 Jun 17, 2024
608184c
Make gen / make docsgen-cli
rjan90 Jun 17, 2024
03fb2e2
chore: api: the Net API/CLI now remains only on daemon
ribasushi Jun 16, 2024
26235d7
Update changelog
rjan90 Jun 17, 2024
2e781e6
fix: events: sqlite db improvements (#12090)
rvagg Jun 14, 2024
c0d760a
Update CHANGELOG.md
rjan90 Jun 17, 2024
b446a39
build: release: v1.27.1-rc2 (#12101)
rjan90 Jun 19, 2024
5fc2192
small fix in changelog
jennijuju Jun 19, 2024
47599c5
Merge pull request #12117 from filecoin-project/phi/v1271-rc2
jennijuju Jun 19, 2024
82e35e9
Merge pull request #12115 from filecoin-project/jen/changlog
jennijuju Jun 19, 2024
9aa0f93
fix: release: update goreleaser config file
rvagg Jun 20, 2024
ac95973
fix go releaser and test with rc3
jennijuju Jun 20, 2024
ef386e3
Merge pull request #12125 from filecoin-project/jen/v1273
jennijuju Jun 20, 2024
efaa998
Update CHANGELOG.md
jennijuju Jun 20, 2024
8e7cd7d
lotus v1.27.1 prep
jennijuju Jun 24, 2024
42fe612
Merge pull request #12137 from filecoin-project/jen/v1271final
jennijuju Jun 24, 2024
69ef408
Merge branch 'release/v1.27.1' into jen/v1271prep
jennijuju Jun 24, 2024
f0dafcb
address review
jennijuju Jun 25, 2024
13f1815
doc: events: note events db migration impact
rvagg Jun 25, 2024
12e9c23
Merge pull request #12140 from filecoin-project/rvagg/changelog-note-…
jennijuju Jun 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: lint: fix lint errors with new linting config
Ref: #11967
  • Loading branch information
rvagg committed May 13, 2024
commit 26d3fd2ecca3e635c4d269df02741b4eb6cb69a5
6 changes: 2 additions & 4 deletions blockstore/buffered.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,9 @@ func (bs *BufferedBlockstore) DeleteMany(ctx context.Context, cids []cid.Cid) er

func (bs *BufferedBlockstore) View(ctx context.Context, c cid.Cid, callback func([]byte) error) error {
// both stores are viewable.
if err := bs.write.View(ctx, c, callback); ipld.IsNotFound(err) {
// not found in write blockstore; fall through.
} else {
if err := bs.write.View(ctx, c, callback); !ipld.IsNotFound(err) {
return err // propagate errors, or nil, i.e. found.
}
} // else not found in write blockstore; fall through.
return bs.read.View(ctx, c, callback)
}

Expand Down
4 changes: 2 additions & 2 deletions blockstore/splitstore/splitstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -282,14 +282,14 @@ func Open(path string, ds dstore.Datastore, hot, cold bstore.Blockstore, cfg *Co
if ss.checkpointExists() {
log.Info("found compaction checkpoint; resuming compaction")
if err := ss.completeCompaction(); err != nil {
markSetEnv.Close() //nolint:errcheck
_ = markSetEnv.Close()
return nil, xerrors.Errorf("error resuming compaction: %w", err)
}
}
if ss.pruneCheckpointExists() {
log.Info("found prune checkpoint; resuming prune")
if err := ss.completePrune(); err != nil {
markSetEnv.Close() //nolint:errcheck
_ = markSetEnv.Close()
return nil, xerrors.Errorf("error resuming prune: %w", err)
}
}
Expand Down
7 changes: 2 additions & 5 deletions blockstore/splitstore/splitstore_compact.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,13 @@ func (s *SplitStore) HeadChange(_, apply []*types.TipSet) error {
// TODO: ok to use hysteresis with no transitions between 30s and 1m?
if time.Since(timestamp) < SyncWaitTime {
/* Chain in sync */
if atomic.CompareAndSwapInt32(&s.outOfSync, 0, 0) {
// already in sync, no signaling necessary
} else {
if !atomic.CompareAndSwapInt32(&s.outOfSync, 0, 0) {
// transition from out of sync to in sync
s.chainSyncMx.Lock()
s.chainSyncFinished = true
s.chainSyncCond.Broadcast()
s.chainSyncMx.Unlock()
}

} // else already in sync, no signaling necessary
}
// 2. protect the new tipset(s)
s.protectTipSets(apply)
Expand Down
2 changes: 1 addition & 1 deletion blockstore/splitstore/splitstore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func init() {
CompactionBoundary = 2
WarmupBoundary = 0
SyncWaitTime = time.Millisecond
logging.SetLogLevel("splitstore", "DEBUG")
_ = logging.SetLogLevel("splitstore", "DEBUG")
}

func testSplitStore(t *testing.T, cfg *Config) {
Expand Down
2 changes: 1 addition & 1 deletion build/builtin_actors_gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"github.com/ipfs/go-cid"
)

var EmbeddedBuiltinActorsMetadata []*BuiltinActorsMetadata = []*BuiltinActorsMetadata{{
var EmbeddedBuiltinActorsMetadata = []*BuiltinActorsMetadata{{
Network: "butterflynet",
Version: 8,

Expand Down
2 changes: 1 addition & 1 deletion build/params_mainnet.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,5 +166,5 @@ const BootstrapPeerThreshold = 4
// As per https://github.com/ethereum-lists/chains
const Eip155ChainId = 314

// we skip checks on message validity in this block to sidestep the zero-bls signature
// WhitelistedBlock skips checks on message validity in this block to sidestep the zero-bls signature
var WhitelistedBlock = MustParseCid("bafy2bzaceapyg2uyzk7vueh3xccxkuwbz3nxewjyguoxvhx77malc2lzn2ybi")
1 change: 1 addition & 0 deletions build/params_shared_vals.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ const MinimumBaseFee = 100
const PackingEfficiencyNum = 4
const PackingEfficiencyDenom = 5

// revive:disable-next-line:exported
// Actor consts
// TODO: pieceSize unused from actors
var MinDealDuration, MaxDealDuration = policy.DealDurationBounds(0)
18 changes: 9 additions & 9 deletions chain/checkpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ func (syncer *Syncer) SyncCheckpoint(ctx context.Context, tsk types.TipSetKey) e
}

hts := syncer.ChainStore().GetHeaviestTipSet()
if hts.Equals(ts) {
// Current head, no need to switch.
} else if anc, err := syncer.store.IsAncestorOf(ctx, ts, hts); err != nil {
return xerrors.Errorf("failed to walk the chain when checkpointing: %w", err)
} else if anc {
// New checkpoint is on the current chain, we definitely have the tipsets.
} else if err := syncer.collectChain(ctx, ts, hts, true); err != nil {
return xerrors.Errorf("failed to collect chain for checkpoint: %w", err)
}
if !hts.Equals(ts) {
if anc, err := syncer.store.IsAncestorOf(ctx, ts, hts); err != nil {
return xerrors.Errorf("failed to walk the chain when checkpointing: %w", err)
} else if !anc {
if err := syncer.collectChain(ctx, ts, hts, true); err != nil {
return xerrors.Errorf("failed to collect chain for checkpoint: %w", err)
}
} // else new checkpoint is on the current chain, we definitely have the tipsets.
} // else current head, no need to switch.

if err := syncer.ChainStore().SetCheckpoint(ctx, ts); err != nil {
return xerrors.Errorf("failed to set the chain checkpoint: %w", err)
Expand Down
6 changes: 2 additions & 4 deletions chain/messagepool/messagepool.go
Original file line number Diff line number Diff line change
Expand Up @@ -778,9 +778,7 @@ func (mp *MessagePool) Add(ctx context.Context, m *types.SignedMessage) error {
_, _ = mp.getStateNonce(ctx, m.Message.From, tmpCurTs)

mp.curTsLk.Lock()
if tmpCurTs == mp.curTs {
//with the lock enabled, mp.curTs is the same Ts as we just had, so we know that our computations are cached
} else {
if tmpCurTs != mp.curTs {
//curTs has been updated so we want to cache the new one:
tmpCurTs = mp.curTs
//we want to release the lock, cache the computations then grab it again
Expand All @@ -789,7 +787,7 @@ func (mp *MessagePool) Add(ctx context.Context, m *types.SignedMessage) error {
_, _ = mp.getStateNonce(ctx, m.Message.From, tmpCurTs)
mp.curTsLk.Lock()
//now that we have the lock, we continue, we could do this as a loop forever, but that's bad to loop forever, and this was added as an optimization and it seems once is enough because the computation < block time
}
} // else with the lock enabled, mp.curTs is the same Ts as we just had, so we know that our computations are cached

defer mp.curTsLk.Unlock()

Expand Down
4 changes: 2 additions & 2 deletions chain/messagepool/selection_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ func testCompetitiveMessageSelection(t *testing.T, rng *rand.Rand, getPremium fu
mustAdd(t, mp, m)
}

logging.SetLogLevel("messagepool", "error")
_ = logging.SetLogLevel("messagepool", "error")

// 1. greedy selection
gm, err := mp.selectMessagesGreedy(context.Background(), ts, ts)
Expand Down Expand Up @@ -1414,7 +1414,7 @@ func testCompetitiveMessageSelection(t *testing.T, rng *rand.Rand, getPremium fu
t.Logf("Average reward boost: %f", rewardBoost)
t.Logf("Average best tq reward: %f", totalBestTQReward/runs/1e12)

logging.SetLogLevel("messagepool", "info")
_ = logging.SetLogLevel("messagepool", "info")

return capacityBoost, rewardBoost, totalBestTQReward / runs / 1e12
}
Expand Down
3 changes: 1 addition & 2 deletions chain/rand/rand.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,8 @@ func (sr *stateRand) GetBeaconRandomness(ctx context.Context, filecoinEpoch abi.
return sr.getBeaconRandomnessV3(ctx, filecoinEpoch)
} else if nv == network.Version13 {
return sr.getBeaconRandomnessV2(ctx, filecoinEpoch)
} else {
return sr.getBeaconRandomnessV1(ctx, filecoinEpoch)
}
return sr.getBeaconRandomnessV1(ctx, filecoinEpoch)
}

func (sr *stateRand) DrawChainRandomness(ctx context.Context, pers crypto.DomainSeparationTag, filecoinEpoch abi.ChainEpoch, entropy []byte) ([]byte, error) {
Expand Down
2 changes: 1 addition & 1 deletion chain/store/snapshot.go
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ func (s *walkScheduler) Wait() error {
log.Errorw("error writing to CAR file", "error", err)
return errWrite
}
s.workerTasks.Close() //nolint:errcheck
_ = s.workerTasks.Close()
return err
}

Expand Down
3 changes: 2 additions & 1 deletion chain/store/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ func (cs *ChainStore) SubHeadChanges(ctx context.Context) chan []*api.HeadChange
// Unsubscribe.
cs.bestTips.Unsub(subch)

// revive:disable-next-line:empty-block
// Drain the channel.
for range subch {
}
Expand Down Expand Up @@ -752,7 +753,7 @@ func FlushValidationCache(ctx context.Context, ds dstore.Batching) error {
for _, k := range allKeys {
if strings.HasPrefix(k.Key, blockValidationCacheKeyPrefix.String()) {
delCnt++
batch.Delete(ctx, dstore.RawKey(k.Key)) // nolint:errcheck
_ = batch.Delete(ctx, dstore.RawKey(k.Key))
}
}

Expand Down
4 changes: 2 additions & 2 deletions chain/sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ type syncTestUtil struct {
}

func prepSyncTest(t testing.TB, h int) *syncTestUtil {
logging.SetLogLevel("*", "INFO")
_ = logging.SetLogLevel("*", "INFO")

g, err := gen.NewGenerator()
if err != nil {
Expand Down Expand Up @@ -115,7 +115,7 @@ func prepSyncTest(t testing.TB, h int) *syncTestUtil {
}

func prepSyncTestWithV5Height(t testing.TB, h int, v5height abi.ChainEpoch) *syncTestUtil {
logging.SetLogLevel("*", "INFO")
_ = logging.SetLogLevel("*", "INFO")

sched := stmgr.UpgradeSchedule{{
// prepare for upgrade.
Expand Down
2 changes: 1 addition & 1 deletion chain/types/ethtypes/eth_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ func NewEthBlockNumberOrHashFromNumber(number EthUint64) EthBlockNumberOrHash {

func NewEthBlockNumberOrHashFromHexString(str string) (EthBlockNumberOrHash, error) {
// check if block param is a number (decimal or hex)
var num EthUint64 = 0
var num EthUint64
err := num.UnmarshalJSON([]byte(str))
if err != nil {
return NewEthBlockNumberOrHashFromNumber(0), err
Expand Down
7 changes: 2 additions & 5 deletions chain/vm/vm.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,19 +336,16 @@ func (vm *LegacyVM) send(ctx context.Context, msg *types.Message, parent *Runtim
return nil, aerrors.Wrapf(err, "could not create account")
}
toActor = a
if vm.networkVersion <= network.Version3 {
// Leave the rt.Message as is
} else {
if vm.networkVersion > network.Version3 {
nmsg := Message{
msg: types.Message{
To: aid,
From: rt.Message.Caller(),
Value: rt.Message.ValueReceived(),
},
}

rt.Message = &nmsg
}
} // else leave the rt.Message as is
} else {
return nil, aerrors.Escalate(err, "getting actor")
}
Expand Down
2 changes: 1 addition & 1 deletion cli/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type BackupApiFn func(ctx *cli.Context) (BackupAPI, jsonrpc.ClientCloser, error)

func BackupCmd(repoFlag string, rt repo.RepoType, getApi BackupApiFn) *cli.Command {
var offlineBackup = func(cctx *cli.Context) error {
logging.SetLogLevel("badger", "ERROR") // nolint:errcheck
_ = logging.SetLogLevel("badger", "ERROR")

repoPath := cctx.String(repoFlag)
r, err := repo.NewFS(repoPath)
Expand Down
6 changes: 3 additions & 3 deletions cli/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ func interactiveDeal(cctx *cli.Context) error {
cs := readline.NewCancelableStdin(afmt.Stdin)
go func() {
<-ctx.Done()
cs.Close() // nolint:errcheck
_ = cs.Close()
}()

rl := bufio.NewReader(cs)
Expand Down Expand Up @@ -2327,7 +2327,7 @@ func OutputDataTransferChannels(out io.Writer, channels []lapi.DataTransferChann
for _, channel := range sendingChannels {
w.Write(toChannelOutput("Sending To", channel, verbose))
}
w.Flush(out) //nolint:errcheck
_ = w.Flush(out)

fmt.Fprintf(out, "\nReceiving Channels\n\n")
w = tablewriter.New(tablewriter.Col("ID"),
Expand All @@ -2341,7 +2341,7 @@ func OutputDataTransferChannels(out io.Writer, channels []lapi.DataTransferChann
for _, channel := range receivingChannels {
w.Write(toChannelOutput("Receiving From", channel, verbose))
}
w.Flush(out) //nolint:errcheck
_ = w.Flush(out)
}

func channelStatusString(status datatransfer.Status) string {
Expand Down
3 changes: 1 addition & 2 deletions cli/info.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,8 @@ func infoCmdAct(cctx *cli.Context) error {
if err != nil {
if strings.Contains(err.Error(), "actor not found") {
continue
} else {
return err
}
return err
}
mbLockedSum = big.Add(mbLockedSum, mbal.Locked)
mbAvailableSum = big.Add(mbAvailableSum, mbal.Escrow)
Expand Down
2 changes: 1 addition & 1 deletion cli/init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ import (
)

func init() {
logging.SetLogLevel("watchdog", "ERROR")
_ = logging.SetLogLevel("watchdog", "ERROR")
}
2 changes: 1 addition & 1 deletion cli/sending_ui.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func printChecks(printer io.Writer, checkGroups [][]api.MessageCheckStatus, prot
func askUser(printer io.Writer, q string, def bool) bool {
var resp string
fmt.Fprint(printer, q)
fmt.Scanln(&resp)
_, _ = fmt.Scanln(&resp)
resp = strings.ToLower(resp)
if len(resp) == 0 {
return def
Expand Down
2 changes: 1 addition & 1 deletion cmd/curio/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/filecoin-project/lotus/node/config"
)

var baseText string = `
var baseText = `
[Subsystems]
# EnableWindowPost enables window post to be executed on this curio instance. Each machine in the cluster
# with WindowPoSt enabled will also participate in the window post scheduler. It is possible to have multiple
Expand Down
2 changes: 1 addition & 1 deletion cmd/lotus-bench/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func (c *CMD) startWorker(qpsTicker *time.Ticker) {

start := time.Now()

var statusCode int = 0
var statusCode int

arr := strings.Fields(c.cmd)

Expand Down
2 changes: 1 addition & 1 deletion cmd/lotus-bench/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ type Commit2In struct {
}

func main() {
logging.SetLogLevel("*", "INFO")
_ = logging.SetLogLevel("*", "INFO")

log.Info("Starting lotus-bench")

Expand Down
2 changes: 1 addition & 1 deletion cmd/lotus-bench/reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (r *Reporter) Print(elapsed time.Duration, w io.Writer) {
return r.latencies[i] < r.latencies[j]
})

var totalLatency int64 = 0
var totalLatency int64
for _, latency := range r.latencies {
totalLatency += latency
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/lotus-fountain/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
var log = logging.Logger("main")

func main() {
logging.SetLogLevel("*", "INFO")
_ = logging.SetLogLevel("*", "INFO")

log.Info("Starting fountain")

Expand Down
2 changes: 1 addition & 1 deletion cmd/lotus-health/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type CidWindow [][]cid.Cid
var log = logging.Logger("lotus-health")

func main() {
logging.SetLogLevel("*", "INFO")
_ = logging.SetLogLevel("*", "INFO")

log.Info("Starting health agent")

Expand Down
4 changes: 2 additions & 2 deletions cmd/lotus-miner/sealing.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func workersCmd(sealing bool) *cli.Command {
ramTotal := stat.Info.Resources.MemPhysical
ramTasks := stat.MemUsedMin
ramUsed := stat.Info.Resources.MemUsed
var ramReserved uint64 = 0
var ramReserved uint64
if ramUsed > ramTasks {
ramReserved = ramUsed - ramTasks
}
Expand All @@ -167,7 +167,7 @@ func workersCmd(sealing bool) *cli.Command {
vmemTotal := stat.Info.Resources.MemPhysical + stat.Info.Resources.MemSwap
vmemTasks := stat.MemUsedMax
vmemUsed := stat.Info.Resources.MemUsed + stat.Info.Resources.MemSwapUsed
var vmemReserved uint64 = 0
var vmemReserved uint64
if vmemUsed > vmemTasks {
vmemReserved = vmemUsed - vmemTasks
}
Expand Down
Loading