fix: harmonydb: Use timestampz instead of timestamp across the schema #12030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
It appears that pgx doesn't pay attention to time.Time timezone field, and fails to convert the time value to whatever Timezone the backing postgres (yb) is configured to run; At the same time our schema uses the
timestamp [without time zone]
type all over the place, and that type accounts for time is units of seconds starting at postgres epoch as defined in the databases local timezone.To make postgres store time in terms of seconds since postgres epoch in UTC we need to switch to
timestampz
(iiuc same type asTIMESTAMP WITH TIME ZONE
), or alternatively doSET TIME ZONE 'UTC'
on all connections - tho that option is much less robust imo (falls apart when external application connects to the database which will then think that it is in a different TZ).Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps