Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui-listen fix #12013

Merged
merged 3 commits into from
May 22, 2024
Merged

gui-listen fix #12013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e04725
gui-listen fix
snadrus May 17, 2024
19ae5d5
Merge branch 'master' into fix/guilisten
LexLuthr May 22, 2024
89f1d91
fix test
LexLuthr May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/curio/deps/deps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ func (deps *Deps) PopulateRemainingDeps(ctx context.Context, cctx *cli.Context,
}
}
}
if cctx.IsSet("gui-listen") {
deps.Cfg.Subsystems.GuiAddress = cctx.String("gui-listen")
}
if deps.LocalStore == nil {
deps.LocalStore, err = paths.NewLocal(ctx, deps.LocalPaths, deps.Si, []string{"http://" + deps.ListenAddr + "/remote"})
if err != nil {
Expand Down
11 changes: 8 additions & 3 deletions cmd/curio/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ var runCmd = &cli.Command{
Value: "0.0.0.0:12300",
EnvVars: []string{"CURIO_LISTEN"},
},
&cli.StringFlag{
Name: "gui-listen",
Usage: "host address and port the gui will listen on",
Hidden: true,
},
&cli.BoolFlag{
Name: "nosync",
Usage: "don't check full-node sync status",
Expand Down Expand Up @@ -157,9 +162,9 @@ var webCmd = &cli.Command{
This creates the 'web' layer if it does not exist, then calls run with that layer.`,
Flags: []cli.Flag{
&cli.StringFlag{
Name: "listen",
Usage: "Address to listen on",
Value: "127.0.0.1:4701",
Name: "gui-listen",
Usage: "Address to listen for the GUI on",
Value: "0.0.0.0:4701",
},
&cli.BoolFlag{
Name: "nosync",
Expand Down
2 changes: 1 addition & 1 deletion documentation/en/cli-curio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ DESCRIPTION:
This creates the 'web' layer if it does not exist, then calls run with that layer.

OPTIONS:
--listen value Address to listen on (default: "127.0.0.1:4701")
--gui-listen value Address to listen for the GUI on (default: "0.0.0.0:4701")
--nosync don't check full-node sync status (default: false)
--layers value [ --layers value ] list of layers to be interpreted (atop defaults). Default: base
--help, -h show help
Expand Down
2 changes: 1 addition & 1 deletion documentation/en/default-curio-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
# The address that should listen for Web GUI requests.
#
# type: string
#GuiAddress = ":4701"
#GuiAddress = "0.0.0.0:4701"


[Fees]
Expand Down
2 changes: 1 addition & 1 deletion node/config/def.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ const (
func DefaultCurioConfig() *CurioConfig {
return &CurioConfig{
Subsystems: CurioSubsystemsConfig{
GuiAddress: ":4701",
GuiAddress: "0.0.0.0:4701",
BoostAdapters: []string{},
RequireActivationSuccess: true,
RequireNotificationSuccess: true,
Expand Down
Loading