Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: docker devnet #11954

Merged
merged 4 commits into from
May 7, 2024
Merged

feat: curio: docker devnet #11954

merged 4 commits into from
May 7, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented May 2, 2024

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr
Copy link
Contributor Author

LexLuthr commented May 2, 2024

@Reiers Can you test this?

@LexLuthr LexLuthr marked this pull request as ready for review May 2, 2024 13:22
@LexLuthr LexLuthr force-pushed the feat/curio-docker branch from 6f0fdf6 to a84fe9b Compare May 3, 2024 07:51
@LexLuthr LexLuthr requested review from magik6k and snadrus May 3, 2024 08:04
@snadrus
Copy link
Collaborator

snadrus commented May 6, 2024

Per his testing, it looks very good, but it requires SUDO because of places that it writes to.
Can we avoid the need for sudo?

@LexLuthr
Copy link
Contributor Author

LexLuthr commented May 7, 2024

@snadrus @Reiers I am using this on a MaC without sudo. Can you confirm your OS? It writes to local home directory and should not require Sudo.

@LexLuthr LexLuthr force-pushed the feat/curio-docker branch from 648cc64 to 64686d9 Compare May 7, 2024 10:49
@LexLuthr
Copy link
Contributor Author

LexLuthr commented May 7, 2024

@snadrus Just confirmed, we don't need sudo filecoin-project/lotus-docs#727 (comment)

@LexLuthr LexLuthr changed the base branch from release/curio-beta to master May 7, 2024 11:19
@LexLuthr LexLuthr changed the base branch from master to release/curio-beta May 7, 2024 11:20
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool

@LexLuthr LexLuthr force-pushed the feat/curio-docker branch from 64686d9 to c5c904d Compare May 7, 2024 11:43
@LexLuthr LexLuthr changed the base branch from release/curio-beta to master May 7, 2024 13:03
@magik6k magik6k merged commit ebf1e00 into master May 7, 2024
185 of 186 checks passed
@magik6k magik6k deleted the feat/curio-docker branch May 7, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants