Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: Datacap should only be checked if user agrees to spend it #11811

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

beck-8
Copy link
Contributor

@beck-8 beck-8 commented Apr 3, 2024

Related Issues

#11810

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@beck-8 beck-8 mentioned this pull request Apr 3, 2024
@LexLuthr LexLuthr changed the title fix rDataCap datacap fix: cli: Datacap should only be checked if user agrees to spend it Apr 3, 2024
@beck-8 beck-8 force-pushed the fix/check_datacap branch from ac7055e to 1dc6781 Compare April 3, 2024 09:57
@LexLuthr LexLuthr merged commit e68b762 into filecoin-project:master Apr 8, 2024
181 of 182 checks passed
@beck-8 beck-8 deleted the fix/check_datacap branch April 9, 2024 03:32
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request May 11, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request May 11, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants