Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: index actor events by actor ID rather than f4 addr #11694

Closed
wants to merge 2 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Mar 7, 2024

Ref: #11594

WIP, notes:

  • This doesn't have a migration, it just starts from a new schema, I started looking at what that would do and there's a little bit of work on a test framework for index migrations. That looked like a fun problem to try and solve and have tests for it.
  • There's an unresolved question in this: what kind of address do we provide back to the user on their events? This PR has a two-way translation, such that your inputs can be non-ID addresses and they'll get translated, but your events will be translated to addresses if they can be, or ID addresses if not. I'm unsure of what the appropriate UX is here.
  • Revisiting this after a month I'm not so confident in the timing of the look-ups - are they being done at the correct tipset wherever we do a translation (see Index Actor Events by ID #11594 for notes about this).

@rvagg
Copy link
Member Author

rvagg commented Apr 2, 2024

better version @ #11723

@rvagg rvagg closed this Apr 2, 2024
@rvagg rvagg deleted the rvagg/index-actor-events-by-id branch April 2, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants