Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch back to upstream ledger library #11651

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

Stebalien
Copy link
Member

Upstream has merged our code to expose a SignatureBytes function, so we can now switch back to using it directly. This also brings bug fixes.

@Stebalien Stebalien requested a review from a team as a code owner February 23, 2024 18:43
@Stebalien Stebalien requested review from snadrus and magik6k February 23, 2024 18:43
@Stebalien Stebalien force-pushed the steb/upstream-ledger branch from 0527501 to 8f5d5d8 Compare February 23, 2024 23:45
@Stebalien
Copy link
Member Author

Requires: #11652

@Stebalien
Copy link
Member Author

Also, apparently this fixes issues on MacOS: Zondax#1.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, gtg once #11652 is dealt with

@Stebalien Stebalien force-pushed the steb/upstream-ledger branch from 8f5d5d8 to 5c99072 Compare February 26, 2024 14:58
Upstream has merged our code to expose a `SignatureBytes` function, so
we can now switch back to using it directly. This also brings bug fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants