Add systemd memory note on install and in config #11641
Conversation
scripts/lotus-daemon.service
Outdated
| MemoryHigh=8G | ||
| MemoryMax=10G |
There was a problem hiding this comment.
| MemoryHigh=8G | |
| MemoryMax=10G | |
| MemoryHigh=16G | |
| MemoryMax=20G |
🤷 my node was struggling to even stay in sync so it would be good to lift this at bit. Suggestions? 12/16 maybe as a compromise if we're still aiming for laptop installs?
There was a problem hiding this comment.
Even just having a MemoryHigh is probably causing heavy performance degradation aside from the memory limitation since the process doesn't get to know this pressure is being applied except that allocation calls are slower and reclamation efforts are more aggressive. Ideally this would be removed entirely but it does get very hungry on some of the big API calls.
|
@f8-ptrk suggested on Slack that we just remove this entirely because they reflect ancient times when these limits were practical. I'm happy to do that, maybe leave a note in there with them commented out suggesting they can be used if it's too much of a hog. Thoughts? |
Agree that it makes sense to get rid of these limits, and rather have them commented out with the suggestion that they can be set. |
|
👍 done. I've removed the note from Makefile that I had in there, we have to assume people are running this and are fairly serious about allocating resources. I've left the Makefile print formatting though. Note left in the service config with those options commented out. I left the fd limits, I think they're probably high enough as they are unless someone thinks otherwise. |
I got caught by this without noticing for a couple of weeks, wondering why my node was behaving so difficult when I tried to do anything non-trivial. I'm also wondering if raising this in general might be a good idea at this point since it seems to be pushing the limit with the size of the blockstore even with minimal history.