Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wdpost: fix vanilla proof indexes #11550

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jan 4, 2024

Related Issues

Proposed Changes

  • Read proofs into an array at fixed indexes instead of appending to a list
    • Appending wasn't deterministic because challenges are read in parallel
  • Then compact skipped vanilla proofs, keeping the correct order

Additional Info

  • Testing:
    • Compute a PoSt with a bunch of sectors per partition (one partition is enough)
    • Compute a PoSt with skipped sectors (disable PoSt pre-checks so that this logic catches bad sectors)

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner January 4, 2024 11:50
@rjan90 rjan90 mentioned this pull request Jan 4, 2024
8 tasks
@snadrus snadrus merged commit 1d75af7 into master Jan 4, 2024
89 checks passed
@snadrus snadrus deleted the fix/worker-multipart-post-err branch January 4, 2024 15:42
rjan90 pushed a commit that referenced this pull request Jan 4, 2024
…post-err

fix: wdpost: fix vanilla proof indexes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants