Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport #11262 #11265

Merged
merged 2 commits into from
Sep 15, 2023
Merged

chore: backport #11262 #11265

merged 2 commits into from
Sep 15, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

Backports #11262

Proposed Changes

This improves some sync issues first reported by @rjan90

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Stebalien and others added 2 commits September 12, 2023 11:32
@Stebalien @arajasek
fix: networking: avoid dialing when trying to handshake peers
9137c62 
Also, avoid handshaking with peers that don't support the handshake
protocol.
@arajasek
drop unused imports
823c589
@arajasek arajasek requested a review from a team as a code owner September 12, 2023 15:33
@arajasek arajasek changed the title Asr/backport libp2p chore: backport #11262 Sep 12, 2023
@Stebalien Stebalien merged commit b9c29d6 into release/v1.23.4 Sep 15, 2023
@Stebalien Stebalien deleted the asr/backport-libp2p branch September 15, 2023 17:36
rjan90 pushed a commit that referenced this pull request Oct 17, 2023
@arajasek @Stebalien @rjan90
chore: backport #11262 (#11265)
f2da80d 
* fix: networking: avoid dialing when trying to handshake peers

Also, avoid handshaking with peers that don't support the handshake
protocol.

* drop unused imports

---------

Co-authored-by: Steven Allen <steven@stebalien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arajasek @Stebalien