Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update PR template to callout remembering to update CHANGELOG #11232

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

fridrik01
Copy link
Contributor

Related Issues

Slack discussion

Proposed Changes

Updating the PR template so remind us that PR which may affect users should be included in the Changelog

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@fridrik01 fridrik01 force-pushed the update-changelog-pr-template branch 2 times, most recently from 9d6281a to 00da4d0 Compare September 1, 2023 17:14
@fridrik01 fridrik01 force-pushed the update-changelog-pr-template branch from 00da4d0 to 5fb41d7 Compare September 1, 2023 18:17
@fridrik01 fridrik01 marked this pull request as ready for review September 1, 2023 18:18
@fridrik01 fridrik01 requested a review from a team as a code owner September 1, 2023 18:18
@jennijuju
Copy link
Member

thank you @fridrik01 !

@jennijuju jennijuju merged commit 4ded4cf into master Sep 1, 2023
@jennijuju jennijuju deleted the update-changelog-pr-template branch September 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants