feat: shed: fix blockstore prune #11197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
023c164 to
484be6d
Compare
Stebalien
commented
Aug 22, 2023
| @@ -225,12 +214,12 @@ var stateTreePruneCmd = &cli.Command{ | |||
| var deleteCount int | |||
| var goodHits int | |||
| for k := range keys { | |||
| if goodSet.HasRaw(k.Bytes()) { | |||
| if goodSet.Has(k) { | |||
There was a problem hiding this comment.
I'm not sure why we did used HasRaw before as this way should bee cheaper.
1. Implement a pass-through for garbage collection on the idstore. 2. Fix the `lotus-shed state-prune` command. NOTE: the new performance of running a full prune will be significantly less as this version doesn't batch. However, it should now actually _work_ and most users will be using the splitstore anyways.
484be6d to
959a554
Compare
magik6k
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
lotus-shed state-prunecommand.NOTE: the new performance of running a full prune will be significantly less as this version doesn't batch. However, it should now actually work and most users will be using the splitstore anyways.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps