Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: fix duplicate check exitcode #11171

Merged

Conversation

simlecode
Copy link
Contributor

@simlecode simlecode commented Aug 15, 2023

Related Issues

Proposed Changes

Double check exitcode: https://github.com/filecoin-project/lotus/blob/master/chain/consensus/compute_state.go#L138-L151

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@simlecode simlecode requested a review from a team as a code owner August 15, 2023 08:29
Copy link
Contributor

@fridrik01 fridrik01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magik6k magik6k merged commit ac85a2e into filecoin-project:master Sep 22, 2023
@simlecode simlecode deleted the opt/remove-repeat-check branch September 26, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants