fix: chainstore: do not get stuck in unhappy equivocation cases #11159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
702eb28 to
12e076e
Compare
Stebalien
reviewed
Aug 12, 2023
| } | ||
| } else { | ||
| // if we haven't found something, just stay with our equivocation-y head | ||
| newHeaviest = cs.heaviest |
There was a problem hiding this comment.
Is there any reason not to just return nil here and move on?
There was a problem hiding this comment.
Yes -- we still want to try and form a tipset at the new height we've been notified about, and take that if it's better?
Stebalien
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
I was doing some manual testing / code inspection of #11104, and realized there's an unfortunate case here where we can get stuck, especially immediately after startup when the
tipsetscache isn't populatedProposed Changes
When refreshing our current head, try to find something within 5 epochs. If we find NOTHING (due to equivocation, or due to the
tipsetscache being unpopulated), just stick with your equivocated head.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps