Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: legacy syscalls: Cleanup ComputeUnsealedSectorCID #11119

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jul 31, 2023

Related Issues

Closes #3322

Proposed Changes

Additional Info

(just a quick fix closing a random issue while I'm waiting for CI on another PR)

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner July 31, 2023 10:45
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- can you take a stab at fixing the (presumably flaky) test, please?

@magik6k magik6k merged commit 683432e into master Aug 2, 2023
@magik6k magik6k deleted the chore/cleanup-compunscid branch August 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify total size in ComputeUnsealedSectorCID
2 participants