Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stores: Tune down StorageDeclareSector` log-lvl #11045

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jul 4, 2023

Related Issues

Closes: #10901

Proposed Changes

Tune down the log-level on StorageDeclareSector to debug.

Additional Info

Boost added an index integrity check in Boost 1.7.0 which causes users to see logs like these more often:

2023-05-22T13:51:13.217Z	WARN	stores	paths/index.go:369	sector {1278 997} redeclared in d8cfac01-4999-45d5-8231-8aa9423224e2

The WARN level here seems wrong as these are expected, and the interval of how often this gets called can be tuned in the configs on Boost.

I have added a KB-article explaining why users might see these logs as well here: https://lotus.filecoin.io/kb/redeclared-sector-log/

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Tune down log-lvl
@rjan90 rjan90 requested a review from a team as a code owner July 4, 2023 07:43
@magik6k magik6k merged commit a5f66b5 into master Jul 6, 2023
@magik6k magik6k deleted the fix/tune-down-log-lvl branch July 6, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeing redeclaring storage tasks several times every day
2 participants