Prefill GetTipsetByHeight skiplist cache on lotus startup #10955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41f4ad5 to
d3fed20
Compare
arajasek
approved these changes
Jun 6, 2023
|
./scripts/fiximports should make CI green |
d3fed20 to
a27e0a8
Compare
1 task
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
GetTipsetByHeightmethod internally maintains a skiplist to more efficiently lookup a tipsets at a given height.When users call a RPC method that call this method (for example
eth_getBlockByNumber) then if this skiplist is not already cached then the user needs to wait until this skiplist is populated in the background which can take 10 minutes or longer.Instead, lets just always populate and fully prefill this skiplist in the background as soon as lotus starts up (only when EnableEthRPC is set). This will not fix the issue, but it will be more likely to give better user experience.
Test plan
Compiled and restarted Lotus and observed the skiplist was generated on startup