feat: run lotus-shed commands in context that is cancelled on sigterm #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
May 22, 2023
cmd/lotus-shed/main.go
Outdated
| go func() { | ||
| <-c | ||
| cancel() | ||
| fmt.Println("Received interrupt, stopping... Press CTRL+C again to force stop") |
There was a problem hiding this comment.
nit: this message confuses me a bit because it makes me think of SIGSTOP and that we are doing something like that. Changing to "shutting down", and "force shut donw" would remove that confusion.
…t SIGTERM/SIGKILL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently,
lotus-shedruns all commands withapp.Run. This makes handling handle interrupts difficult or even impossible from the client side (urfave/cli#945). We would like to be able to interrupt (CTRL+C) all our commands such that they can gracefully exit, or if that fails force them to stop (right now we need to do a manual SIGKILL)This diff
Updates
lotus-shedto run all commands withapp.RunContext()and pass it a context that we cancel on interrupt frommain(). This allows each command to simply check forctx.Done()and gracefully exit (we can add that incrementally later).Implementation notes:
cancel()does not in all cases gracefully exit as it seems that we not thoroughly check for Done in all codepaths. Therefore, added a second forced stop.