Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: chain: replace storetheindex with go-libipni #10841

Merged
merged 2 commits into from
May 22, 2023
Merged

chore: chain: replace storetheindex with go-libipni #10841

merged 2 commits into from
May 22, 2023

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented May 5, 2023 •
edited
Loading

Proposed Changes

Replace dependencies on packages in storetheindex with equivalents in go-libipni.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • [N/A] New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@gammazero gammazero mentioned this pull request May 5, 2023
Closed
@gammazero gammazero marked this pull request as ready for review May 17, 2023 19:12
@gammazero gammazero requested a review from a team as a code owner May 17, 2023 19:12
ZenGround0
ZenGround0 approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purlely out of curiosity what does the NI stand for in IPNI?

@gammazero
Copy link
Contributor Author

@ZenGround0 ..NI == "..Network Indexer"

@ZenGround0 ZenGround0 merged commit 2922959 into filecoin-project:master May 22, 2023
@gammazero gammazero deleted the use-go-libipni branch June 2, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gammazero @ZenGround0