Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unseal: check if sealed/update sector exists #10639

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Apr 10, 2023

Related Issues

fixes: #10222

Proposed Changes

Check if storiface.FTSealed or storiface.FTUpdate sector exists when SectorsUnsealPiece is called, and fail if they are not present.

Additional Info

lotus-miner storage find 111
In 94f8a49e-1208-442d-b960-9c6fca5ec2a0 (Cache)
        Sealing: true; Storage: true
        Local (/root/.lotus-miner-local-net)
        URL: http://127.0.0.1:2345/remote/cache/s-t01000-111
lotus-miner sectors unseal 111
ERROR: sealed or updated sector file not found for sector {1000 111}

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Check if sealed or update sector exists when `SectorsUnsealPiece` is called.
@rjan90 rjan90 requested a review from a team as a code owner April 10, 2023 08:23
@rjan90 rjan90 merged commit cb22349 into master Apr 20, 2023
@rjan90 rjan90 deleted the fix/fail-unseal-removed-sector branch April 20, 2023 07:03
@rjan90 rjan90 mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to unseal a removed sector should fail instantly
2 participants