-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make execution trace configurable via env variable #10585
feat: Make execution trace configurable via env variable #10585
Conversation
We want to make the execution trace cache size configurable as SPs may want to disable it while exchanges may want to crank it up. We were also are going with intuition for this value, so having ability to change it without a new build would help. Fixes: #10584
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable, just a comment on initialkzation.
@@ -74,6 +75,17 @@ func (m *migrationResultCache) keyForMigration(root cid.Cid) dstore.Key { | |||
return dstore.NewKey(kStr) | |||
} | |||
|
|||
func init() { | |||
if s := os.Getenv("LOTUS_EXEC_TRACE_CACHE"); s != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to LOTUS_EXEC_TRACE_CACHE_SIZE
@@ -40,8 +42,7 @@ import ( | |||
const LookbackNoLimit = api.LookbackNoLimit | |||
const ReceiptAmtBitwidth = 3 | |||
|
|||
const execTraceCacheSize = 16 | |||
|
|||
var defaultExecTraceCacheSize = 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the old name? Because if the envvar is set, we set this field, which means it's no longer a default size?
Related Issues
#10584
#10504
Proposed Changes
We want to make the execution trace cache size configurable as SPs may want to disable it while exchanges may want to crank it up.
We were also are going with intuition for this value, so having ability to change it without a new build would help.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps