Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github: Discussion and FIP links in New Issue #10268

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Feb 14, 2023

Related Issues

Part of #10242

Proposed Changes

In our current issue flow, we ask a lot checklist questions in our bug reports:

- This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
- This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue. *

While they are there to guide people to the right place for troubleshooting/questions, they make our Issue template very text dense and complex.

This information can instead be displayed in the New Issue chooser which has better UI, and will link users to the relevant place for posting. This file will add two new entries in the issue chooser:

  • A entry that links to the Lotus Github Discussion page for Lotus questions/troubleshooting
  • A entry that links to the FIPs repo for Filecoin protocol feature or enhancements

Additional Info

Example of how these links will now be displayed instead:
Screenshot 2023-02-14 at 11 04 20

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

In our current issue flow, we ask a lot checklist questions :

`This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.`
`This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue. *`

This information is better displayed in the `New Issue` chooser, to guide users to the relevant place for posting. This file will add two new entries in the issue chooser:
- A entry that links to the Lotus Github Discussion pager for Lotus questions or troubleshooting
- A entry that links to the FIPs repo for Filecoin protocol feature or enhancements
@rjan90 rjan90 requested a review from a team as a code owner February 14, 2023 10:23
rjan90 added a commit that referenced this pull request Feb 16, 2023
Update enhancement and feature_request templates:

- Removing unnecessary checklist options.
   - These have been move to the Github New Issue UI to reduce text overhead: #10268
- Remove deprecated components options
- Add FVM/FEVM component
@jennijuju jennijuju merged commit 52197cc into master Mar 8, 2023
@jennijuju jennijuju deleted the add-discussion-fip-links branch March 8, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants