Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cli: Remove unneeded individual color flags #10028

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Thanks to @FlattestWhite for #10022

Proposed Changes

We now have global color flags for all functions in lotus and lotus-miner cli.

if cctx.IsSet("color") {

if cctx.IsSet("color") {

I've removed all the redundant individual flags.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner January 16, 2023 15:18
@geoff-vball geoff-vball changed the title Remove unneeded individual color flags chore: cli: Remove unneeded individual color flags Jan 16, 2023
@travisperson
Copy link
Contributor

If there is a global flag, I think we should remove the color flag from all these commands as well right?

@geoff-vball
Copy link
Contributor Author

geoff-vball commented Jan 19, 2023

You're right. Thanks @travisperson. I've updated the PR

@geoff-vball geoff-vball force-pushed the gstuart/cli-color-cleanup branch from 307ed48 to c6f2066 Compare January 19, 2023 04:09
@geoff-vball geoff-vball force-pushed the gstuart/cli-color-cleanup branch from c6f2066 to 807a60b Compare January 23, 2023 16:11
@magik6k magik6k merged commit 13fc5b6 into master Jan 31, 2023
@magik6k magik6k deleted the gstuart/cli-color-cleanup branch January 31, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants