Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] libp2p yamux bug showing up in deal-making #6602

Closed
jennijuju opened this issue Jun 25, 2021 · 4 comments
Closed

[BUG] libp2p yamux bug showing up in deal-making #6602

jennijuju opened this issue Jun 25, 2021 · 4 comments
Assignees
Labels
area/markets Area: Markets kind/bug Kind: Bug P0 P0: Critical Blocker

Comments

@jennijuju
Copy link
Member

The current market in master may have trouble with making deals with nodes that on v1.10.0 and below - miner is observing that when deals being initiated, graphsync doesn't send any blocks.

Before the issue got fixed in go-libp2p, the immediate thing action we can takeon lotus is to downgrade just the yamux dependency (github.com/libp2p/go-libp2p-yamux v0.4.1) via a go mod replace,

@jennijuju jennijuju added hint/needs-triaging kind/bug Kind: Bug area/markets Area: Markets P0 P0: Critical Blocker and removed hint/needs-triaging labels Jun 25, 2021
@jennijuju jennijuju added this to the v1.11.0 milestone Jun 25, 2021
@raulk
Copy link
Member

raulk commented Jun 25, 2021

This is not a market protocol incompatibility, but rather an issue with the latest go-libp2p dependencies.

Downgrading go-libp2p-yamux to github.com/libp2p/go-libp2p-yamux v0.4.0 via a go.mod replace directive fixes this. @magik6k will post a PR/patch soon to rectify the situation in master.

We will need a integration test reproducing this issue reliably so we can debug what's the regression in yamux.

@raulk raulk changed the title [BUG] Market Incompatibility [BUG] libp2p yamux incompatibility showing up in deal-making Jun 25, 2021
@raulk raulk changed the title [BUG] libp2p yamux incompatibility showing up in deal-making [BUG] libp2p yamux bug showing up in deal-making Jun 25, 2021
raulk added a commit to raulk/whitenoise that referenced this issue Jun 25, 2021
@raulk
Copy link
Member

raulk commented Jun 25, 2021

Reproduction with testground here: https://github.com/raulk/whitenoise/compare/repro/lotus-6602

@arajasek arajasek removed this from the v1.11.0 milestone Jun 29, 2021
@arajasek
Copy link
Contributor

1.11 works around this by downgrading

@BlocksOnAChain
Copy link
Contributor

@arajasek @raulk anything else we need to consider for this one or we can close it, since It’s classified as P0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/markets Area: Markets kind/bug Kind: Bug P0 P0: Critical Blocker
Projects
None yet
Development

No branches or pull requests

5 participants