drand: fix beacon cache

filecoin-project · Apr 30, 2021 · ab811e2 · ab811e2
1 parent eb10918
commit ab811e2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/chain/beacon/drand/drand.go b/chain/beacon/drand/drand.go
@@ -168,8 +168,8 @@ func (db *DrandBeacon) getCachedValue(round uint64) *types.BeaconEntry {
 	if !ok {
 		return nil
 	}
-	e, _ := v.(*types.BeaconEntry)
-	return e
+	e, _ := v.(types.BeaconEntry)
+	return &e
 }
 
 func (db *DrandBeacon) VerifyEntry(curr types.BeaconEntry, prev types.BeaconEntry) error {
@@ -178,6 +178,9 @@ func (db *DrandBeacon) VerifyEntry(curr types.BeaconEntry, prev types.BeaconEntr
 		return nil
 	}
 	if be := db.getCachedValue(curr.Round); be != nil {
+		if !bytes.Equal(curr.Data, be.Data) {
+			return xerrors.New("invalid beacon value, does not match cached good value")
+		}
 		// return no error if the value is in the cache already
 		return nil
 	}