fix: storage: Remove temp fetching files after failed fetch

filecoin-project · Apr 13, 2023 · 7a4f697 · 7a4f697
1 parent a7379e2
commit 7a4f697
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/storage/paths/remote.go b/storage/paths/remote.go
@@ -236,6 +236,10 @@ func (r *Remote) acquireFromRemote(ctx context.Context, s abi.SectorID, fileType
 			err = r.fetchThrottled(ctx, url, tempDest)
 			if err != nil {
 				merr = multierror.Append(merr, xerrors.Errorf("fetch error %s (storage %s) -> %s: %w", url, info.ID, tempDest, err))
+				// fetching failed, remove temp file
+				if rerr := os.RemoveAll(tempDest); rerr != nil {
+					merr = multierror.Append(merr, xerrors.Errorf("removing temp dest (post-err cleanup): %w", rerr))
+				}
 				continue
 			}