review fixes

.circleci/config.yml

@@ -874,6 +874,11 @@ workflows:
           suite: itest-get_messages_in_ts
           target: "./itests/get_messages_in_ts_test.go"
 
+      - test:
+          name: test-itest-lookup_robust_address
+          suite: itest-lookup_robust_address
+          target: "./itests/lookup_robust_address_test.go"
+
       - test:
           name: test-itest-mempool
           suite: itest-mempool

chain/stmgr/stmgr.go

@@ -354,13 +354,10 @@ func (sm *StateManager) LookupRobustAddress(ctx context.Context, idAddr address.
 		}
 		return nil
 	})
-	if err != nil {
-		if robustAddr == address.Undef {
-			return address.Undef, xerrors.Errorf("finding address: %w", err)
-		}
-		return robustAddr, nil
+	if robustAddr == address.Undef {
+		return address.Undef, xerrors.Errorf("finding address: %w", err)
 	}
-	return address.Undef, xerrors.Errorf("address not found")
+	return robustAddr, nil
 }
 
 func (sm *StateManager) ValidateChain(ctx context.Context, ts *types.TipSet) error {

itests/lookup_robust_address_test.go

@@ -0,0 +1,32 @@
+package itests
+
+import (
+	"context"
+	"testing"
+	"time"
+
+	"github.com/filecoin-project/go-state-types/network"
+	"github.com/filecoin-project/lotus/chain/types"
+	"github.com/filecoin-project/lotus/itests/kit"
+	"github.com/stretchr/testify/require"
+)
+
+func TestStateLookupRobustAddress(t *testing.T) {
+	ctx := context.Background()
+	kit.QuietMiningLogs()
+
+	client, miner, ens := kit.EnsembleMinimal(t, kit.MockProofs(), kit.GenesisNetworkVersion(network.Version15))
+	ens.InterconnectAll().BeginMining(10 * time.Millisecond)
+
+	addr, err := miner.ActorAddress(ctx)
+	require.NoError(t, err)
+
+	// Look up the robust address
+	robAddr, err := client.StateLookupRobustAddress(ctx, addr, types.EmptyTSK)
+	require.NoError(t, err)
+
+	// Check the id address for the given robust address and make sure it matches
+	idAddr, err := client.StateLookupID(ctx, robAddr, types.EmptyTSK)
+	require.NoError(t, err)
+	require.Equal(t, addr, idAddr)
+}

itests/self_sent_txn_test.go

@@ -102,23 +102,3 @@ func TestSelfSentTxnV14(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, exitcode.Ok, mLookup.Receipt.ExitCode)
 }
-
-func TestStateLookupRobustAddress(t *testing.T) {
-	ctx := context.Background()
-	kit.QuietMiningLogs()
-
-	client, miner, ens := kit.EnsembleMinimal(t, kit.MockProofs(), kit.GenesisNetworkVersion(network.Version15))
-	ens.InterconnectAll().BeginMining(10 * time.Millisecond)
-
-	addr, err := miner.ActorAddress(ctx)
-	require.NoError(t, err)
-
-	// Look up the robust address
-	robAddr, err := client.StateLookupRobustAddress(ctx, addr, types.EmptyTSK)
-	require.NoError(t, err)
-
-	// Check the id address for the given robust address and make sure it matches
-	idAddr, err := client.StateLookupID(ctx, robAddr, types.EmptyTSK)
-	require.NoError(t, err)
-	require.Equal(t, addr, idAddr)
-}

node/impl/full/state.go

@@ -454,12 +454,6 @@ func (a *StateAPI) StateLookupRobustAddress(ctx context.Context, addr address.Ad
 	if err != nil {
 		return address.Undef, xerrors.Errorf("loading tipset %s: %w", tsk, err)
 	}
-	if ts.Height() > policy.ChainFinality {
-		ts, err = a.StateManager.ChainStore().GetTipsetByHeight(ctx, ts.Height()-policy.ChainFinality, ts, true)
-		if err != nil {
-			return address.Undef, xerrors.Errorf("failed to load lookback tipset: %w", err)
-		}
-	}
 
 	return a.StateManager.LookupRobustAddress(ctx, addr, ts)
 }