-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: refactor: actor bundling system (#8838)
1. Include the builtin-actors in the lotus source tree. 2. Embed the bundle on build instead of downloading at runtime. 3. Avoid reading the bundle whenever possible by including bundle metadata (the bundle CID, the actor CIDs, etc.). 4. Remove everything related to dependency injection. 1. We're no longer downloading the bundle, so doing anything ahead of time doesn't really help. 2. We register the manifests on init because, unfortunately, they're global. 3. We explicitly load the current actors bundle in the genesis state-tree method. 4. For testing, we just change the in-use bundle with a bit of a hack. It's not great, but using dependency injection doesn't make any sense either because, again, the manifest information is global. 5. Remove the bundle.toml file. Bundles may be overridden by specifying an override path in the parameters file, or an environment variable. fixes #8701
- Loading branch information
Showing
52 changed files
with
658 additions
and
843 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Bundles | ||
|
||
This directory includes the actors bundles for each release. Each actor bundle is a zstd compressed | ||
tarfile containing one bundle per network type. These tarfiles are subsequently embedded in the | ||
lotus binary. | ||
|
||
## Updating | ||
|
||
To update, run the `./pack.sh` script. For example, the following will pack the [builtin actors release](https://github.com/filecoin-project/builtin-actors/releases) `dev/20220602` into the `v8` tarfile. | ||
|
||
```bash | ||
./pack.sh v8 dev/20220602 | ||
``` | ||
|
||
This will: | ||
|
||
1. Download the actors bundles and pack them into the appropriate tarfile (`$VERSION.tar.zst`). | ||
2. Run `make bundle-gen` in the top-level directory to regenerate the bundle metadata file for _all_ network versions (all `*.tar.zst` files in this directory). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/bin/bash | ||
|
||
set -e | ||
|
||
if [[ $# -ne 2 ]]; then | ||
echo "expected two arguments, an actors version (e.g., v8) and an actors release" | ||
exit 1 | ||
fi | ||
|
||
VERSION="$1" # actors version | ||
RELEASE="$2" # actors release name | ||
NETWORKS=(devnet mainnet caterpillarnet butterflynet testing testing-fake-proofs) | ||
|
||
echo "Downloading bundles for actors version ${VERSION}, release ${RELEASE}" | ||
|
||
TARGET_FILE="$(pwd)/${VERSION}.tar.zst" | ||
WORKDIR=$(mktemp --tmpdir -d "actor-bundles-${VERSION}.XXXXXXXXXX") | ||
trap 'rm -rf -- "$WORKDIR"' EXIT | ||
|
||
pushd "${WORKDIR}" | ||
encoded_release="$(jq -rn --arg release "$RELEASE" '$release | @uri')" | ||
for network in "${NETWORKS[@]}"; do | ||
wget "https://github.com/filecoin-project/builtin-actors/releases/download/${encoded_release}/builtin-actors-${network}"{.car,.sha256} | ||
done | ||
|
||
echo "Checking the checksums..." | ||
|
||
sha256sum -c -- *.sha256 | ||
|
||
|
||
echo "Packing..." | ||
|
||
rm -f -- "$TARGET_FILE" | ||
tar -cf "$TARGET_FILE" -I "zstd -19" -- *.car | ||
popd | ||
|
||
echo "Generating metadata..." | ||
|
||
make -C ../../ bundle-gen |
Binary file not shown.
Oops, something went wrong.