Fix rance in GetBestMiningCandidate

Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
filecoin-project · Jun 23, 2020 · 29bfd8a · 29bfd8a
1 parent 156a14e
commit 29bfd8a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/api/test/mining.go b/api/test/mining.go
@@ -133,11 +133,10 @@ func TestDealMining(t *testing.T, b APIBuilder, blocktime time.Duration, carExpo
 			wait := make(chan int, 2)
 			mdone := func(mined bool) {
 				go func() {
-					n := 0
 					if mined {
-						n = 1
+						wait <- 1
 					}
-					wait <- n
+					wait <- 0
 				}()
 			}
 

diff --git a/miner/miner.go b/miner/miner.go
@@ -215,6 +215,9 @@ type MiningBase struct {
 }
 
 func (m *Miner) GetBestMiningCandidate(ctx context.Context) (*MiningBase, error) {
+	m.lk.Lock()
+	defer m.lk.Unlock()
+
 	bts, err := m.api.ChainHead(ctx)
 	if err != nil {
 		return nil, err