This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: filecoin-project/lassie#345
Needs this done on the current DB to bring it up to the schema in here:
As is, with filecoin-project/lassie#345 deployed, this would add an attempt per peer that's involved in a bitswap retrieval, it'll also tag those that are Filecoin SPs in the prometheus metrics. I don't think we currently have insight into how many peers are involved in a retrieval, on average, so I'm not sure how much extra chatter this is going to add to the database.
It won't do anything with the number of bytes transferred per provider other than slot that into the database. We may need to reflect further on the dashboard regarding how/if we want to include that somehow (e.g. some kind of ranking per bytes transferred? maybe a Filecoin SP was involved in a bitswap retrieval but contributed a single block to a 100 block retrieval, do we care?).