This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Record metrics to prometheus #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfe659a to
570ded3
Compare
masih
suggested changes
Mar 9, 2023
eventrecorder/recorder.go
Outdated
| handleQueryAskEvent() | ||
| case types.QueryAskedFilteredCode: | ||
| handleQueryAskFilteredEvent() | ||
| } |
There was a problem hiding this comment.
log warning on default case. This would be useful to detect missing cases when lassie types are updated but this code is not.
redesign metrics to target opentelemetry, handle events in intelligent ways, and produce usable lassie metrics
masih
approved these changes
Mar 11, 2023
Co-authored-by: Masih H. Derkani <m@derkani.org>
Co-authored-by: Masih H. Derkani <m@derkani.org>
rvagg
reviewed
Mar 13, 2023
| atomic.StoreUint32(&t.failedCount, 0) | ||
| } | ||
|
|
||
| var tempDataPool = sync.Pool{ |
There was a problem hiding this comment.
I gather that we're just relying on the sheer volume of traffic to wipe out the errors introduced by GC wiping away our data occasionally, giving us not-quite-accurate finality reports? With a very busy service, I wonder whether GC is going to get really disruptive here and make this very inaccurate?
also adds setup for docker compose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Put some metrics into the event recorder so we can verify that we've got a prometheus flow moving end to end.
Implementation
For now I just took the metrics recorder from Lassie directly and did a best effort translation to try to record some metrics. Some of these have a few deficiencies but it's all going to change once we ship filecoin-project/lassie#138
For discussion
Remove that summary endpoint, cause it never worked and was a terrible idea