Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffi and update markets to v9 #751

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Sep 26, 2022

Note: Currently pointing at a dangling commit of go-state-types.

Updates markets to v9 which is required for the nv17 upgrade in lotus.

@geoff-vball geoff-vball force-pushed the gstuart/bump-gst-markets-version branch 2 times, most recently from 8b320ac to 94bd764 Compare September 29, 2022 19:49
@geoff-vball geoff-vball force-pushed the gstuart/bump-gst-markets-version branch from 94bd764 to 764f9a0 Compare September 29, 2022 19:50
@arajasek
Copy link
Collaborator

Let's merge this and tag it as v1.24.1-rc1. This will be for the Filecoin network v17 upgrade.

@arajasek arajasek merged commit f79b60c into master Sep 29, 2022
@geoff-vball geoff-vball deleted the gstuart/bump-gst-markets-version branch September 29, 2022 21:29
@hannahhoward
Copy link
Collaborator

@arajasek I'm late to this party but we have some pending features branches we'd like to release pre-v17 upgrade, for boost and filclient.

can we speak one on one about what we plan to do here? (given impending deprecations to be announced -- cc @jennijuju )

@jennijuju
Copy link
Member

@arajasek I'm late to this party but we have some pending features branches we'd like to release pre-v17 upgrade, for boost and filclient.

can we speak one on one about what we plan to do here? (given impending deprecations to be announced -- cc @jennijuju )

unfortunately id like to avoid that
https://filecoinproject.slack.com/archives/CP50PPW2X/p1663707244492419

@jennijuju
Copy link
Member

@hannahhoward tho we can test v1.12.4 in lotus nov feature release

geoff-vball added a commit that referenced this pull request Oct 7, 2022
@hannahhoward
Copy link
Collaborator

ok -- let's make 1.24.1 or 1.24.0-v17 a LOTUS nv17 ONLY release (no new features). Then we can ship a 1.25.0 on top of that into boost with new features included. If Lotus discovers later there was something wrong with v1.24.1, we can branch additional changes off 1.24.1 to make 1.24.2 and so on, then merge them into master to mantain a unified commit history.

The only delta for you all is if you have to make additional changes to support NV17, you branch of 1.24.1 to avoid receiving new features that you probably don't want to ship with the network upgrade.

Also, with upcoming deprecation plans, it probably makes sense for Lotus to have its own maintainence branch any way.

sound good @jennijuju?

@jennijuju
Copy link
Member

jennijuju commented Oct 8, 2022

I’m not too sure - cuz as long as we are supporting lotus client, we might want to keep update on some of the gfm changes. I need to think about it more! But the nv17 branch stuff sgtm, thank you for understanding (in retrospect I should’ve tagged you in that thread and get a sign off on the branching strategy - sorry for the oversight!

hannahhoward added a commit that referenced this pull request Oct 10, 2022
hannahhoward added a commit that referenced this pull request Oct 12, 2022
hannahhoward added a commit that referenced this pull request Oct 18, 2022
Co-authored-by: Geoff Stuart <geoff.vball@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants