-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/no block chain ops #190
Conversation
218d235
to
3b4659d
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 67.83% 68.13% +0.30%
==========================================
Files 38 39 +1
Lines 2070 2108 +38
==========================================
+ Hits 1404 1436 +32
- Misses 563 569 +6
Partials 103 103
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a misunderstanding about what the add funds flow looks like.
Regardless of what flow I use, I have no actual payment info when I start the deal.
When the deal is accepted, I go to DealStatusAccepted, and call GetOrCreatePaymentChannel.
If I previously created a separate transaction (i.e. another retrieval deal), GetOrCreatePaymentChannel will return that payment channel, at which point I need to save it in the deal, and wait for the adding fund message to process.
When the adding funds message finishes, I need to still create a new lane for this deal. And save that information.
Then the deal proceeds the same as it would from DealStatePaymentChannelReady
I've put what I believe are the various corrections needed to do this flow, but I think the first step is to have the integration test have a test case where it specifically tests the add flow. This will help reveal if we are doing it right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome!
Closes #69 Retrieval should not block on chain operations