Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce exit sleep in tests run with race detector to zero #820

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

masih
Copy link
Member

@masih masih commented Jan 13, 2025

Reduce exit sleep in tests run with race detector to zero to make the tests run faster.

Reduce exit sleep in tests run with race detector to zero
to make the tests run faster.
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (c4b5f6a) to head (7ed3714).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   68.82%   68.71%   -0.11%     
==========================================
  Files          81       81              
  Lines        8307     8307              
==========================================
- Hits         5717     5708       -9     
- Misses       2100     2109       +9     
  Partials      490      490              

see 5 files with indirect coverage changes

@masih masih marked this pull request as ready for review January 13, 2025 15:29
@masih
Copy link
Member Author

masih commented Jan 13, 2025

Looking at the CI run, this shaved off 1 minute from go test --race ./... compared to main.

@masih masih requested a review from Kubuxu January 13, 2025 15:30
@masih masih enabled auto-merge January 13, 2025 15:30
@BigLep BigLep added this to the M2: Mainnet Passive Testing milestone Jan 14, 2025
@masih masih added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit fb71a30 Jan 14, 2025
14 checks passed
@masih masih deleted the masih/ci-go-test-race-exsleep-0 branch January 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants