Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase message and subscription buffer size to 128 #762

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

masih
Copy link
Member

@masih masih commented Nov 28, 2024

Increase the pubsub and internal message queue buffer sizes to 128. This is to allow a larger headroom for buffered messages if the internal message handling loop is too slow, or in a case where there is a slight missalignment across nodes on bootstrap.

Fixes #759

@masih masih marked this pull request as draft November 28, 2024 15:23
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (c4d8f53) to head (e021971).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   69.81%   69.71%   -0.11%     
==========================================
  Files          74       74              
  Lines        7553     7557       +4     
==========================================
- Hits         5273     5268       -5     
- Misses       1869     1876       +7     
- Partials      411      413       +2     
Files with missing lines Coverage Δ
host.go 66.02% <100.00%> (+0.65%) ⬆️

... and 3 files with indirect coverage changes

Increase the pubsub and internal message queue buffer sizes to 128. This
is to allow a larger headroom for buffered messages if the internal
message handling loop is too slow, or in a case where there is a slight
missalignment across nodes on bootstrap.

Relates to #759
@masih masih force-pushed the masih/investigate-sub-too-slow branch from 5749516 to e021971 Compare December 3, 2024 13:41
@masih masih changed the title Increase message buffer sizes to 100 and sub buffer size to 64 Increase message and subscription buffer size to 128 Dec 3, 2024
@masih masih marked this pull request as ready for review December 3, 2024 13:42
@masih masih requested a review from Kubuxu December 3, 2024 13:42
@masih masih added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit b4e2522 Dec 3, 2024
13 checks passed
@masih masih deleted the masih/investigate-sub-too-slow branch December 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate subscriber too slow errors in pubsub
2 participants