Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce explicit error type for F3 disabled and no manifest #797

Closed
masih opened this issue Dec 13, 2024 · 0 comments · Fixed by #798
Closed

Introduce explicit error type for F3 disabled and no manifest #797

masih opened this issue Dec 13, 2024 · 0 comments · Fixed by #798
Assignees
@masih

Comments

@masih
Copy link
Member

masih commented Dec 13, 2024 •
edited
Loading

Additional to the conversation in filecoin-project/lotus#12781 (comment),
can I also ask that these two particular instances be turned into a publicly accessible error vars? The "no known network manifest" would be a good one too. Then we could do some easy checks and pass on our own typed errors in lotus for these common cases.

Originally posted by @rvagg in #795 (comment)
@github-project-automation github-project-automation bot moved this to Todo in F3 Dec 13, 2024
@masih masih mentioned this issue Dec 13, 2024
Closed
@masih masih self-assigned this Dec 13, 2024
@masih masih moved this from Todo to In progress in F3 Dec 13, 2024
masih added a commit that referenced this issue Dec 13, 2024
@masih
Introduce sentinel errors for F3 not running and unknown manifest
40dcfbb 
For better upstream logic flow introduce sentinel errors to signal:
* when F3 is not running,
* when manifest is not known.

Fixes #797
masih added a commit that referenced this issue Dec 13, 2024
@masih
Introduce sentinel errors for F3 not running and unknown manifest
895fc3f 
For better upstream logic flow introduce sentinel errors to signal:
* when F3 is not running,
* when manifest is not known.

Fixes #797
@masih masih mentioned this issue Dec 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2024
@masih
Introduce sentinel errors for F3 not running and unknown manifest (#798)
fde5157 
For better upstream logic flow introduce sentinel errors to signal:
* when F3 is not running,
* when manifest is not known.

Fixes #797
@github-project-automation github-project-automation bot moved this from In progress to Done in F3 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce sentinel errors for F3 not running and unknown manifest filecoin-project/go-f3
1 participant
@masih