Added standard (un)marshalBinary methods #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: without these hooks go-filecoin can't serialize any object that contains an embedded address so this PR is needed for gfc interop.
Long version: While gfc makes an effort to play nice with cbg encodings it can only fallback to cbg encode/decode on the top level type being enc/decoded. We would need to use cbg on all datastructures, or write our own complete cbor library that is aware of the cbg marshaling interface signatures in order for embedded datatypes implementing the cbg interfaces to be handled automatically without making this change. Another alternative I proposed here would be to make the cbg interface standardized so that external code could handle cbg interfaces automatically.
The functions introduced satisfy a relevant standard go interface so adding this code is good practice independent of the gfc motivation.