-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose beacon randomness through new EVM precompile via new runtime method (FIP-0095) #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessarily mixing in additional entropy. Expose beacon randomness through new EVM precompile.
anorth
force-pushed
the
anorth/rand-precompile
branch
from
August 26, 2024 22:51
ca3aff5
to
6cb6fd3
Compare
1 task
Stebalien
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the right approach.
ZenGround0
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I'll wait on approval until there are some tests
Now with tests. |
ZenGround0
approved these changes
Aug 28, 2024
anorth
changed the title
Expose beacon randomness through new EVM precompile via new runtime method.
Expose beacon randomness through new EVM precompile via new runtime method (FIP-0095)
Aug 29, 2024
Stebalien
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a runtime method for fetching drand beacon randomness without necessarily mixing in additional entropy. Expose beacon randomness through new EVM precompile.
There is some redundancy in the runtime methods here. The mixing of entropy could be factored out of the existing runtime beacon randomness method and into a wrapper function. I have code for this, but it has moderate impact on existing tests, which check randomness values assuming this mixing happened inside the runtime layer.
This is an alternative to #1576.