Convert SectorDealIDs to an alias for Vec<DealID>, removing struct #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jan 29, 2024
Stebalien
approved these changes
Jan 30, 2024
|
@rvagg I rebased on master since the prior base is now merged there, but looks like some other commits got dragged in. Could you fix this up? |
11a92ec to
f3794ad
Compare
|
done, and squashed the fixup while I was there |
Stebalien
approved these changes
Jan 31, 2024
|
I've attempted to resolve the conflict with master, waiting for CI... |
f17131a to
028f18f
Compare
|
rebased the original locally and force pushed it, should be gtg now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from a question I raised in filecoin-project/FIPs#930 about the wrapping of an array in a struct, this is seeing what it looks like with that done in code.