Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefactor: align on ActorState in state checks #1447

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

alexytsu
Copy link
Contributor

No description provided.

@alexytsu alexytsu requested a review from anorth October 16, 2023 23:55
@codecov-commenter
Copy link

Codecov Report

Merging #1447 (6fb1e7a) into master (9a2166c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage   90.93%   90.98%   +0.05%     
==========================================
  Files         146      146              
  Lines       27972    27965       -7     
==========================================
+ Hits        25437    25445       +8     
+ Misses       2535     2520      -15     
Files Coverage Δ
state/src/check.rs 86.05% <100.00%> (-0.04%) ⬇️
vm_api/src/lib.rs 91.66% <100.00%> (-2.78%) ⬇️

... and 3 files with indirect coverage changes

@Stebalien
Copy link
Member

I'm also happy to export ActorState from fvm_shared.

Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good here, and could you file an issue with FVM to export it, and we can take that one after they release.

@alexytsu alexytsu added this pull request to the merge queue Oct 18, 2023
Merged via the queue into master with commit b136ad8 Oct 18, 2023
13 checks passed
@alexytsu alexytsu deleted the alexytsu/test-vm-prefactors branch October 18, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants