Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prove replica update multi dline bug #138

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Fix prove replica update multi dline bug #138

merged 4 commits into from
Mar 31, 2022

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Mar 25, 2022 •
edited
Loading

Mirror fix in specs-actors here.

When PRU specifies multiple deadlines this should not cause failure.

Calling out no merge because this is consensus breaking. This goes in wherever the v8 changes are merging.

@ZenGround0 ZenGround0 force-pushed the fix/pru-multi-dline branch from 7220aba to 6db0a25 Compare March 25, 2022 19:51
@jennijuju jennijuju requested review from Stebalien and arajasek March 25, 2022 19:54
@ZenGround0 ZenGround0 force-pushed the fix/pru-multi-dline branch from 6db0a25 to d29fd73 Compare March 25, 2022 20:33
@ZenGround0
Copy link
Contributor Author

Rebased on clippy fixes

@ZenGround0 ZenGround0 force-pushed the fix/pru-multi-dline branch from d29fd73 to 099a34b Compare March 25, 2022 21:15
@ZenGround0 ZenGround0 changed the title NO MERGE: needs new network version. Fix prove replica update multi dline bug Fix prove replica update multi dline bug Mar 28, 2022
arajasek
arajasek reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a sanity check on the length of new_sectors below (where we do success_len != validated_updates.len())

Stebalien
Stebalien approved these changes Mar 29, 2022
View reviewed changes
actors/miner/src/lib.rs Outdated Show resolved Hide resolved
@ZenGround0 ZenGround0 force-pushed the fix/pru-multi-dline branch from ce7b197 to 3d86198 Compare March 31, 2022 19:35
@ZenGround0 ZenGround0 merged commit 3117746 into master Mar 31, 2022
@ZenGround0 ZenGround0 deleted the fix/pru-multi-dline branch March 31, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek left review comments

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Network v16 (Skyr) - FVM M1 Upgrade
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZenGround0 @Stebalien @arajasek