feat: FVM no longer draws randomness for you #1378
Conversation
runtime/src/runtime/fvm.rs
Outdated
| match e { | ||
| ErrorNumber::LimitExceeded => { | ||
| actor_error!(illegal_argument; "randomness lookback exceeded: {}", e) | ||
| } | ||
| e => actor_error!(assertion_failed; "get chain randomness failed with an unexpected error: {}", e), | ||
| } | ||
| }) | ||
| })?; | ||
| Ok(draw_randomness(&digest, personalization, rand_epoch, entropy)) |
There was a problem hiding this comment.
I was initially intending to do this in the SDK but... yeah, it actually makes sense to do it here given that the FVM doesn't really care about how the user draws randomness anyways.
So LGTM?
There was a problem hiding this comment.
Yeah, this seems like the better thing to do? It does mean that all contracts need to implement their own "drawing" logic, but that's a good thing, arguably.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## asr/next #1378 +/- ##
===========================================
Coverage ? 90.76%
===========================================
Files ? 145
Lines ? 27286
Branches ? 0
===========================================
Hits ? 24766
Misses ? 2520
Partials ? 0 |
| @@ -19,3 +21,63 @@ pub enum DomainSeparationTag { | |||
| PoStChainCommit = 9, | |||
| EvmPrevRandao = 10, | |||
| } | |||
|
|
|||
| pub fn draw_randomness( | |||
There was a problem hiding this comment.
Clippy is convinced this is unused, because it is only called from the FVM-specific code. Is there a more sophisticated way to fix this than slapping allow(unused) on it?
| @@ -19,3 +21,63 @@ pub enum DomainSeparationTag { | |||
| PoStChainCommit = 9, | |||
| EvmPrevRandao = 10, | |||
| } | |||
|
|
|||
| pub fn draw_randomness( | |||
|
You'll need to rebase as well. |
6a76d41 to
ce83ed7
Compare
ce83ed7 to
8ddec2f
Compare
8ddec2f to
dc11008
Compare
Integrates filecoin-project/ref-fvm#1848 from the FVM
nextworkstream.Test to come.