Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch state claims to change O(n) calls to Lotus State to O(1) #1946

Conversation

RobQuistNL
Copy link
Contributor

Old branch that might still be a valid improvement

In my case (140.000 updates) shaves off 1.5 seconds per call (+ the load on the daemon) -> turns a 39 hour job into seconds
@LexLuthr
Copy link
Collaborator

LexLuthr commented Aug 5, 2024

Not sure why this PR was opened. Main already have these changes.

func (d *Doctor) checkPiece(ctx context.Context, pieceCid cid.Cid, lu *sectorstatemgr.SectorStateUpdates, head *types.TipSet, claims map[verifregtypes.ClaimId]verifregtypes.Claim) error {

@RobQuistNL
Copy link
Contributor Author

So this branch was already merged? 🤔 I thought it was weird. I don't know why GH is not showing it is already merged, and why its clearly showing the diff and no information about main being outdated...

@RobQuistNL
Copy link
Contributor Author

Yep; #1855

@RobQuistNL RobQuistNL closed this Aug 5, 2024
@RobQuistNL RobQuistNL reopened this Aug 5, 2024
@RobQuistNL RobQuistNL closed this Aug 5, 2024
@RobQuistNL RobQuistNL deleted the RobQuistNL-patch-piecedoctor-prefetch branch August 5, 2024 09:58
@LexLuthr
Copy link
Collaborator

LexLuthr commented Aug 5, 2024

So this branch was already merged? 🤔 I thought it was weird. I don't know why GH is not showing it is already merged, and why its clearly showing the diff and no information about main being outdated...

This caught me off guard as well. I manually checked the diff because I remembered you opening a PR for this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants