feat(gocql): add authentication support #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strahe This will need to be implemented on Curio side as well. Yb would be common for both. If Yb has auth enabled then we will need client auth on both sides. |
|
@LexLuthr It appears that Curio only uses YSQL interface. Did I miss anything? |
|
@LexLuthr Can you review this again? We really need this feature. As far as I know, YCQL is not used in Curio, so it does not affect Curio. |
|
@strahe Have you tested this? Can you please add an auth test? |
|
@LexLuthr Tested and already in use in our production environment. Do you mean adding a test screenshot or a test case script? |
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are useing Yugabyte with YCQL authentication enabled via the parameter
--use_cassandra_authenticationand YSQL authentication enabled via--ysql_enable_auth.However,
boostd-datais unable to utilize Cassandra authentication and can only connect using YSQL authorization through the connection string.This PR enables users to authenticate using Cassandra credentials.