fix: handle complete checkpoint in UI deal list #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Dec 7, 2023
| @@ -648,6 +648,9 @@ func (dr *dealResolver) SealingState(ctx context.Context) string { | |||
| if dr.ProviderDealState.Checkpoint < dealcheckpoints.AddedPiece { | |||
| return "To be sealed" | |||
| } | |||
| if dr.ProviderDealState.Checkpoint == dealcheckpoints.Complete { | |||
| return "Complete" | |||
There was a problem hiding this comment.
if this displays as Sealing: Complete we should probably come up with better naming.
There was a problem hiding this comment.
It will display "Complete" not "Sealing: Complete". I have added a description as well in the informative.
nonsense
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in UI where if a deal never gets added to a sector and moved to "Complete" checkpoint due to an error then the UI displays the sealing status of sector "0".