FIP-0076: Add AggregateProofType parameter to ProveCommitSectors3Params. #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennijuju
approved these changes
Dec 26, 2023
|
the change LGTM - out of curiosity, do we need to define a RegisteredAggregateProof enum in builtin actor for this change? |
I don't think so, these are the same proofs. |
d091e16 to
7eca687
Compare
kaitlin-beegle
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit proof type parameter to ProveCommitSectors2Params, rather than hardcoding SnarkPackV2. This follows the pattern already used by ProveReplicaUpdates[2] and supports development of new proofs without necessarily changing method signature.
I don't believe this is a substantive change that should require restarting Last Call.
Suggested by @Kubuxu